Avoid adding extra comma separator if File input is empty or null #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cawllec
reviewed
Apr 10, 2018
| @@ -49,6 +49,10 @@ public void value(@Nullable Streamable streamable) throws IOException { | |||
| * Writes a File (its content) into the stream | |||
| */ | |||
| public void value(@NonNull File file) throws IOException { | |||
| if (file == null || file.length() <= 0) { | |||
There was a problem hiding this comment.
Do you need the null check if @NonNull is used above?
There was a problem hiding this comment.
@NonNull doesn't enforce anything in Java unfortunately. The IDE would highlight any null parameters with a warning, but developers could choose to ignore this.
Pezzah
approved these changes
Apr 11, 2018
rich-bugsnag
pushed a commit
that referenced
this pull request
Sep 3, 2021
Avoid using jcenter() in Unity gradle scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the file input was null or empty, an additional comma was added by the JSON serialiser as a separator, leading to invalid JSON, e.g.
[{}, , {}]. This can lead to session/error payloads being dropped as invalid.This fixes JSON serialisation so that a comma is not included in this case, e.g.
[{}, {}]This doesn't fix the case where a file is non-empty but isn't valid JSON, which will be addressed separately.